Safeguard ctrl-mgr cancel func in ExtensionController

jnummelin commented 2 months ago

Currently we blindly call the cancel func and there are some cases when it actually can be nil.

Description

Fixes #4930

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

[ ] Manual test
[ ] Auto test added

Checklist:

[ ] My code follows the style guidelines of this project
[ ] My commit messages are signed-off
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

k0s-bot commented 2 months ago

Backport failed for release-1.28, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.28
git worktree add -d .worktree/backport-4937-to-release-1.28 origin/release-1.28
cd .worktree/backport-4937-to-release-1.28
git switch --create backport-4937-to-release-1.28
git cherry-pick -x 6e94f763825c93ca7a5fa0899f79251398ee2d1b

k0s-bot commented 2 months ago

Backport failed for release-1.29, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.29
git worktree add -d .worktree/backport-4937-to-release-1.29 origin/release-1.29
cd .worktree/backport-4937-to-release-1.29
git switch --create backport-4937-to-release-1.29
git cherry-pick -x 6e94f763825c93ca7a5fa0899f79251398ee2d1b

k0s-bot commented 2 months ago

Successfully created backport PR for release-1.30:

4940

k0sproject / k0s