Remove GetRESTClient
This was accessing the client field without locking the mutex and was potentially missing initialization. The dynamic client is actually exposing its REST client, so that can be used instead.
Use k0s's clientset in the k0s client factory
Keep the old CRD specific versions for backwards compatibility.
Lazy initialization for metadata client in Autopilot update checks
This allows FakeClientFactory.GetRESTConfig method to panic without breaking tests. Code constructed with an empty rest.Config is not backed by a fake client at all, so it's better to have tests fail up front than to have strange errors when such constructed clients are actually used.
Lazy initialization in client factory's GetRESTClient
Previously, the GetRESTClient method was not synchronized and not concurrency safe. Callers could get a nil pointer under certain circumstances. Change this by adding mutexes and making it use lazy initialization like all other getters. This means that this method needs to be fallible.
Introduce LoadRESTConfig function pointer
This way, the way the REST config is loaded is up to the client factory users. The special "admin" settings are now part of the controller command, freeing the client factory from any particular way of loading and setting up the config.
Type of change
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
How Has This Been Tested?
[ ] Manual test
[ ] Auto test added
Checklist:
[x] My code follows the style guidelines of this project
Description
Remove
GetRESTClientThis was accessing the client field without locking the mutex and was potentially missing initialization. The dynamic client is actually exposing its REST client, so that can be used instead.Use k0s's clientset in the k0s client factory Keep the old CRD specific versions for backwards compatibility.
Lazy initialization for metadata client in Autopilot update checks This allows
FakeClientFactory.GetRESTConfigmethod to panic without breaking tests. Code constructed with an empty rest.Config is not backed by a fake client at all, so it's better to have tests fail up front than to have strange errors when such constructed clients are actually used.Lazy initialization in client factory's
GetRESTClientPreviously, theGetRESTClientmethod was not synchronized and not concurrency safe. Callers could get a nil pointer under certain circumstances. Change this by adding mutexes and making it use lazy initialization like all other getters. This means that this method needs to be fallible.Introduce
LoadRESTConfigfunction pointer This way, the way the REST config is loaded is up to the client factory users. The special "admin" settings are now part of the controller command, freeing the client factory from any particular way of loading and setting up the config.Type of change
How Has This Been Tested?
Checklist: