Drop kardianos/service dependency

k0sproject / k0s

k0s - The Zero Friction Kubernetes

https://docs.k0sproject.io

Other

3.59k stars 358 forks source link

Drop kardianos/service dependency #4962

Open jnummelin opened 3 weeks ago

jnummelin commented 3 weeks ago

We anyways already provide our own templates for system units and thus do not depend that much on the library functionality.

kardianos/service is not really maintained, there's e.g. a bug fix PR opened by myself on June 2023 which has not been merged.

I propose that we drop the whole dependency, use our own templates fully and provide needed wrappers around. We handle much of the same/similar logic in k0sctl/rig side already and thus known what needs to be done.

kke commented 3 weeks ago

Detect init system (done in https://github.com/k0sproject/rig/tree/main/initsystem)
Write out the template (they are already in go text/template format in k0s sources)
Implement k0s start and k0s stop (also implemented in the same files in rig)