Open chattytak opened 6 days ago
Looking at the stack trace, looks like Helm is choking on trying to figure out the chart version. Could you try with adding a version
field to the config?
Thanks for doing the research. As you taught me, I added the version tag and it installed correctly. I am not familiar with OCI, but when installing with the normal helm command, it installs correctly without the version specification. Is this a bug that k0s has?
Is this a bug that k0s has?
That I'm not 100% sure yet. 😄
k0s uses Helm as a library so there has been some discrepancies between it's CLI usage and how it behaves as a library in the past.
What I'm currently leaning towards is that when you use Helm via CLI and do NOT specify --version
, it'll default to latest
(at least when using OCI). That seems to happen as a separate step before the actual install part and thus k0s is not doing that.
However, I must say that using latest
is a bad idea in this case, similarly as for container images. You can find lot of discussion on the downsides, and regrets, when using latest
with images. IMO most of the things apply to charts too.
As Jussi mentioned, the panic happens because of the missing version, but that's only part of it. In fact, I suspect the panic would happen for any version that isn't a valid semver. IIUC the course of events is as follows:
nil
.nil
...This only happens if the charts are downloaded via OCI, and only if the chart version is not a valid semver.
So this is definitely a bug on k0s' side. The question is how to fix it:
Either way, a panic is obviously not a good outcome.
Heh, I based my assumptions on the Helm CLI --version
help text:
If this is not specified, the latest version is used
So in this case the latest version
is determined by looking at all the tags and like you @twz123 said, doing some "clever semver stuff" 😄
Before creating an issue, make sure you've checked the following:
Platform
Linux 5.14.0-362.24.2.el9_3.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Mar 30 14:11:54 EDT 2024 x86_64 GNU/Linux NAME="AlmaLinux" VERSION="9.3 (Shamrock Pampas Cat)" ID="almalinux" ID_LIKE="rhel centos fedora" VERSION_ID="9.3" PLATFORM_ID="platform:el9" PRETTY_NAME="AlmaLinux 9.3 (Shamrock Pampas Cat)" ANSI_COLOR="0;34" LOGO="fedora-logo-icon" CPE_NAME="cpe:/o:almalinux:almalinux:9::baseos" HOME_URL="https://almalinux.org/" DOCUMENTATION_URL="https://wiki.almalinux.org/" BUG_REPORT_URL="https://bugs.almalinux.org/"
ALMALINUX_MANTISBT_PROJECT="AlmaLinux-9" ALMALINUX_MANTISBT_PROJECT_VERSION="9.3" REDHAT_SUPPORT_PRODUCT="AlmaLinux" REDHAT_SUPPORT_PRODUCT_VERSION="9.3"
Version
v1.31.1+k0s.1
Sysinfo
`k0s sysinfo`
What happened?
I tried to install OCI using the Helm extension and got an error.
Steps to reproduce
1. 2. 3.
Expected behavior
No response
Actual behavior
No response
Screenshots and logs
Additional context
No response