k0sproject / k0smotron

k0smotron
https://docs.k0smotron.io/
Other
430 stars 40 forks source link

Skipping etcd certs checks when Kine is used #570

Closed makhov closed 2 months ago

makhov commented 2 months ago

The regression in the v0.9.5 is fixed.

We don't check for etcd certs if KineDataSourceURL is not an empty string. But currently it doesn't work with KineDataSourceSecretName. We do the following to make it work, but by mistake, we pass kmc not by reference and this doesn't change the KineDataSourceURL and the check works wrongly

if kmc.Spec.KineDataSourceSecretName != "" {
    kmc.Spec.KineDataSourceURL = kineDataSourceURLPlaceholder
}
jnummelin commented 2 months ago

I don't get how this fixes the issue, maybe bit more explanation on the commit message might help

makhov commented 2 months ago

Added a comment