search

k0sproject / k0smotron

k0smotron
https://docs.k0smotron.io/
Other
430 stars 40 forks source link

fix: add missing fsgroup option otherwise etcd couldn't read the dataDir #574

Closed cwrau closed 1 month ago

jnummelin commented 2 months ago

@cwrau The linter is not happy, could you have a look?

Schnitzel commented 1 month ago

btw, I'm running into exact same issue, just for me it works with fsGroup: 0 but fsGroup: 1001 should also work.

I'm confused though why tests previously passed without this, as I can't get it running unless this is set.

makhov commented 1 month ago

Thanks for the contribution!

Schnitzel commented 1 month ago

@makhov I know this might be nitpicky, but do we know why the tests didn't catch this? In my testing I was not able to create an etcd cluster at all (I was using Hetzner Cloud storage), maybe it is possible that during the tests we use a storage volume for etcd that does not use any linux permission? But I feel linux permissions should be super standard and also be caught during testing?

makhov commented 1 month ago

@Schnitzel We use rancher/local-path-provisioner in our tests and it runs mkdir -m 0777 -p "$VOL_DIR" on volume provisioning. I'm thinking about switching to openebs/dynamic-localpv-provisioner for our tests

cwrau commented 1 month ago

@makhov sorry, I was on holiday, thanks for taking care of this 😅

Great that this got addressed so quickly!