search

k13132 / openwrt-dpdk

Data Plane Development Kit (DPDK) integration into OpenWrt
26 stars 12 forks source link

vfio-pci: add dependency on vfio-pci-core #7

Closed pprindeville closed 1 year ago

pprindeville commented 1 year ago

vfio-pci depends on vfio-pci-core

zokl commented 1 year ago

Hello, your PR is for the master version of OpenWRT, stable branch 22.03 is without vfio support, and the used kernel does not include the Vfio-pci-core module. I check the necessary of my own vfio modules for the master version of OpenWrt.

pprindeville commented 1 year ago

The intention is to rationalize what's already in master with the additional support needed for DPDK and get everything in one place upstream.

Since vfio and vfio-pci are already built in master, all that's really necessary is packaging for the user-space runtime.

pprindeville commented 1 year ago

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

zokl commented 1 year ago

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue https://github.com/openwrt/openwrt/issues/12631 and test everything over our codes.

pprindeville commented 1 year ago

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

zokl commented 1 year ago

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

Yes, this issue is for last master's version of 22.03.

pprindeville commented 1 year ago

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

Yes, this issue is for last master's version of 22.03.

I can't reproduce it.

pprindeville commented 1 year ago

Have you tried building with MUSL? That's what most of OpenWRT builds with.

zokl commented 1 year ago

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

Yes, this issue is for last master's version of 22.03.

I can't reproduce it.

I have fresh openwrt master environment with glibc enabled.

zokl commented 1 year ago

Have you tried building with MUSL? That's what most of OpenWRT builds with.

Musl works without problem. GLIBC has a problem. I am not able to compile DPDK on musl version of OpenWRT. I need to use GLIBC version.

zokl commented 1 year ago

Have you tried building with MUSL? That's what most of OpenWRT builds with.

Musl works without problem. GLIBC has a problem. I am not able to compile DPDK on musl version of OpenWRT. I need to use GLIBC version.

I use this tutorial: https://github.com/k13132/openwrt-dpdk/blob/main/README.md

pprindeville commented 1 year ago

Have you tried building with MUSL? That's what most of OpenWRT builds with.

Musl works without problem. GLIBC has a problem. I am not able to compile DPDK on musl version of OpenWRT. I need to use GLIBC version.

Because of the <execinfo.h> issue? Yeah, I'm working on a patch for that...

The issue there is that we're using the canned settings in config/rte_config.h for RTE_BACKTRACE, for instance. That should only be set if CONFIG_LIBC == glibc (or CONFIG_USE_GLIBC, etc.)