Fixes for Rubocop and Rspec

k1LoW / awsecrets

AWS credentials loader

MIT License

17 stars 9 forks source link

Fixes for Rubocop and Rspec #28

Closed glasswalk3r closed 4 years ago

glasswalk3r commented 4 years ago

The "fixes" for Rubocop are actually disabling asserts that are not passing, probably because Rubocop is now more demanding than in the past. Those new disabled asserts should be enabled back and fixed I guess.

Anyway, travis.yml is updated to follow the rubocop-performance requirements, as well the .rubocop.yml file.

Actually declaring the rubocop-performance as a development requirement for awsecrets.

Fixed a typo within the spec/configuration_spec.rb.

k1LoW commented 4 years ago

Hi @glasswalk3r !! Could you merge master ?

glasswalk3r commented 4 years ago

Hi @glasswalk3r !! Could you merge master ?

Done!

k1LoW commented 4 years ago

Thank you!

k1LoW commented 3 years ago

Released as v1.15.0.