Added Aws::EC2::Client config checking

k1LoW / awsecrets

AWS credentials loader

MIT License

17 stars 9 forks source link

Added Aws::EC2::Client config checking #29

Closed glasswalk3r closed 3 years ago

glasswalk3r commented 4 years ago

If the environment variable DISABLE_AWS_CLIENT_CHECK is properly configured, now awsecrets will attempt to create an Aws::EC2::Client.new (discarding it latter) in order to validate if all configuration parameters are in place. Documentation updated to reflect that. Since that by default this will not change the previous behavior, the change should not have any impact clients unaware of DISABLE_AWS_CLIENT_CHECK environment variable.

glasswalk3r commented 4 years ago

Kind like messed up putting documentation changes together with those from #26 :-( Let me know if that would be a problem (considering that the #26 is not approved).

glasswalk3r commented 4 years ago

@k1LoW , I've merged with #21 and things are looking good now! Could you please take a look?

glasswalk3r commented 4 years ago

@k1LoW , I got a positive feedback from #21 . Could please check and approve this PR? Thanks!

k1LoW commented 3 years ago

@glasswalk3r Sorry !!!! sorry for the late reply !!

k1LoW commented 3 years ago

Released as v1.15.0.