search

k1LoW / awsecrets

AWS credentials loader
MIT License
17 stars 9 forks source link

Changed exception to error message #30

Closed glasswalk3r closed 4 years ago

glasswalk3r commented 4 years ago

Instead of raising a timeout exception when trying to reach AWS EC2 metadata, now the attempted will only generate an error message into STDERR.

glasswalk3r commented 4 years ago

Not sure although if there is a better way to check on this... maybe some default environment variable in EC2 instances that could be used to check if awsecret is actually running on EC2 or not?

k1LoW commented 4 years ago

Thank you !!! @glasswalk3r !!!! GREAT !!!

Could you merge master branch ? ( Looks CI still fail

glasswalk3r commented 4 years ago

Done!

k1LoW commented 4 years ago

maybe some default environment variable in EC2 instances that could be used to check if awsecret is actually running on EC2 or not?

No, there is not.

glasswalk3r commented 4 years ago

Well, I guess that all we can do for now. Or maybe create an specific exception to be rescued? Anyway, I guess this is ready to be merged. :-D

k1LoW commented 4 years ago

Oh! Thank you !!

k1LoW commented 3 years ago

Released as v1.15.0.