ACM's domain_name is not unique

k1LoW / awspec

RSpec tests for your AWS resources.

MIT License

1.17k stars 192 forks source link

Closed htnosm closed 6 years ago

htnosm commented 6 years ago

Returns incorrect value when same domain name exists in ACM test. I think it would be better to support testing with arn like lambda resource type.

Does anyone have an idea?

inokappa commented 6 years ago

@htnosm

Thank you for your issue.

I think it would be better to support testing with arn like lambda resource type.

👍 I also agree with that.

inokappa commented 6 years ago

Hi, all (@htnosm , @k1LoW )

I am planning to fix it with the following policy.

Enable to specify domain name or ARN
Returning exception error Awspec :: DuplicatedResourceTypeError, when domain name is duplicated

In Japanese.

以下のようなポリシーで修正しようと思います.

htnosm さん, ありがとうございます 🙇

htnosm commented 6 years ago

@inokappa Thank you for your support.

After updating, I confirmed the test success on ARN and duplication error at domain_name. Please close this issue.

inokappa commented 6 years ago

@htnosm

Thank you for your comment & check. Closed.