search

k1LoW / awspec

RSpec tests for your AWS resources.
MIT License
1.17k stars 192 forks source link

Patches for RouteTable, CloudWatchLogs and CloudTrail resources #480

Closed tjjjwxzq closed 5 years ago

tjjjwxzq commented 5 years ago

This PR adds three commits that patch some methods in the RouteTable, CloudWatchLogs and CloudTrail resources, due to holes we found while using this at work.

RouteTable#target_gateway?: modifies the check for when gateway_id points to a NAT gateway, to ensure that both an ID and name work for the gateway_id value RouteTable#target_nat?: modifies the check so that both an ID and name work for the nat_gateway_id value

Added has_tags? to the CloudWatchLogs and CloudTrail resources to allow for use of the have_tag matcher in specs. This required patching the corresponding finders to user the necessary AWS SDK methods to fetch the tags separately.

k1LoW commented 5 years ago

Hi @tjjjwxzq ! Thank you for your commit!!!!

tjjjwxzq commented 5 years ago

I'm going to close this PR and re-open another one with a different target branch instead of the master of my fork, as there are some other patches that I want to push in and to open as separate PRs (to keep things organized)