search

k1LoW / awspec

RSpec tests for your AWS resources.
MIT License
1.17k stars 193 forks source link

#443: SSM Parameters pagination issue, replaced with get_parameter AP… #481

Open cthulhu opened 5 years ago

cthulhu commented 5 years ago

Replaced ssm parameters describe API call with get_parameter call to fix pagination issue.

Fixed specs and changed a bit behavior of the spec for ssm. It has a few values less now because of the differences in APIs. However, it also has value now. So we can test against it if it is not encrypted.

k1LoW commented 5 years ago

Hi @cthulhu . Thank you for your pull request !!! According to the documentation, describe_parameters seems to be able to get all parameters using next_token .

cthulhu commented 5 years ago

@k1LoW Indeed, however, the code would become a bit more complex if you would iterate over the params. Besides, API has an endpoint to fetch 1 param info. Perhaps we could go with that? Otherwise, I can change it but it will take some time.

k1LoW commented 5 years ago

@cthulhu

I care about the difference in interface.

It has a few values less now because of the differences in APIs

Otherwise, I can change it but it will take some time.

Thank you !

anjo-swe commented 10 months ago

@k1LoW @cthulhu create a new PR (https://github.com/k1LoW/awspec/pull/583) that uses pagination