search

k1LoW / awspec

RSpec tests for your AWS resources.
MIT License
1.17k stars 192 forks source link

Add a second check for "Throttling" exception to ClientWrap #512

Closed carolinebeauchamp closed 4 years ago

carolinebeauchamp commented 4 years ago

So, even with the ClientWrap meant to be doing exponential backoff/retry I was still getting failures due to rate limit throttling.

Dug a bit into the code and realised that the exception being thrown didn't match the exception expected by the code to retry, so added the one I was getting to the retry criteria.

Now not getting throttling errors

k1LoW commented 4 years ago

Hi @carolinebeauchamp . Thank you for your commit !!!

Could you fix failed rubocop lint ?

carolinebeauchamp commented 4 years ago

Hi @carolinebeauchamp . Thank you for your commit !!!

Could you fix failed rubocop lint ?

Done, but travis is failing a test - can't reproduce the failure locally here though :( Any thoughts?

k1LoW commented 4 years ago

@carolinebeauchamp Thank you !

Done, but travis is failing a test

Could you check this ?

carolinebeauchamp commented 4 years ago

Ahhh - missed the "troubleshooting" part - a bundle update has been done and that should (🤞) fix it

Thanks!