search

k1LoW / awspec

RSpec tests for your AWS resources.
MIT License
1.17k stars 193 forks source link

Security group rule #514

Closed carolinebeauchamp closed 4 years ago

carolinebeauchamp commented 4 years ago

So, this adds in extra tests for inbound and outbound rules.... It is currently failing rubocop, because it says the class is too long... it was longer that this, so I'm not sure how to make it much shorter! The only thing I can think of is to remove all the code to check individual ports, because in some senses that's obsolete, now we're testing the actual rules.

But that would break anyone who's using those tests at the moment (not that I think they work properly) - so would welcome suggestions.

thanks

Caroline

k1LoW commented 4 years ago

👀

k1LoW commented 4 years ago

Released as v1.19.2.