search

k1LoW / runn

runn is a package/tool for running operations following a scenario.
https://runn.run
MIT License
421 stars 31 forks source link

Add `skipCircularReferenceCheck` for skipping circular reference check in the OpenAPI3 document. #1027

Closed k1LoW closed 2 weeks ago

k1LoW commented 2 weeks ago

Fix https://github.com/k1LoW/runn/issues/1026

github-actions[bot] commented 2 weeks ago

BenchmarkManyRunbooks-4

main (-) #1027 (8aa7109) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,960,103,435 ns/op 3,813,762,918 ns/op -146,340,517 ns/op
Bytes allocated per iteration 1,786,338,024 B/op 1,786,115,608 B/op -222,416 B/op
Allocs per iteration 21,134,987 allocs/op 21,135,708 allocs/op 721 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([8aa7109](https://github.com/k1LoW/runn/commit/8aa7109b15eb769d08c137cfcad062b039c427ff)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkOpenAPI3-4

main (-) #1027 (8aa7109) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,606,547,098 ns/op 4,776,436,558 ns/op 169,889,460 ns/op
Bytes allocated per iteration 2,217,650,336 B/op 2,217,652,976 B/op 2,640 B/op
Allocs per iteration 30,844,828 allocs/op 30,840,198 allocs/op -4,630 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([8aa7109](https://github.com/k1LoW/runn/commit/8aa7109b15eb769d08c137cfcad062b039c427ff)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkSingleRunbook-4

main (-) #1027 (8aa7109) +/-
Number of iterations 19 18 -1
Nanoseconds per iteration 62,875,835 ns/op 63,741,743 ns/op 865,908 ns/op
Bytes allocated per iteration 60,120,320 B/op 60,112,457 B/op -7,863 B/op
Allocs per iteration 205,388 allocs/op 205,403 allocs/op 15 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([8aa7109](https://github.com/k1LoW/runn/commit/8aa7109b15eb769d08c137cfcad062b039c427ff)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

Reported by octocov

github-actions[bot] commented 2 weeks ago

BenchmarkManyRunbooks-4

main (-) #1027 (8b1cefa) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,929,689,004 ns/op 4,103,002,052 ns/op 173,313,048 ns/op
Bytes allocated per iteration 1,786,118,728 B/op 1,786,524,160 B/op 405,432 B/op
Allocs per iteration 21,135,144 allocs/op 21,135,633 allocs/op 489 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([8b1cefa](https://github.com/k1LoW/runn/commit/8b1cefa4eedabb40ee1ed5ed8b10ca773392a051)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkOpenAPI3-4

main (-) #1027 (8b1cefa) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,040,890,664 ns/op 4,610,954,367 ns/op -429,936,297 ns/op
Bytes allocated per iteration 2,217,857,760 B/op 2,217,938,776 B/op 81,016 B/op
Allocs per iteration 30,841,518 allocs/op 30,842,413 allocs/op 895 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([8b1cefa](https://github.com/k1LoW/runn/commit/8b1cefa4eedabb40ee1ed5ed8b10ca773392a051)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkSingleRunbook-4

main (-) #1027 (8b1cefa) +/-
Number of iterations 16 18 2
Nanoseconds per iteration 67,334,157 ns/op 64,903,616 ns/op -2,430,541 ns/op
Bytes allocated per iteration 60,137,881 B/op 60,114,038 B/op -23,843 B/op
Allocs per iteration 205,415 allocs/op 205,401 allocs/op -14 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([8b1cefa](https://github.com/k1LoW/runn/commit/8b1cefa4eedabb40ee1ed5ed8b10ca773392a051)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

Reported by octocov

github-actions[bot] commented 2 weeks ago

BenchmarkManyRunbooks-4

main (-) #1027 (2d152d7) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,092,218,655 ns/op 4,145,377,590 ns/op 53,158,935 ns/op
Bytes allocated per iteration 1,786,760,776 B/op 1,786,142,048 B/op -618,728 B/op
Allocs per iteration 21,135,845 allocs/op 21,135,140 allocs/op -705 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([2d152d7](https://github.com/k1LoW/runn/commit/2d152d71d024bf560c5f553dc331a6f34fc17b83)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkOpenAPI3-4

main (-) #1027 (2d152d7) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,593,344,826 ns/op 4,633,858,613 ns/op 40,513,787 ns/op
Bytes allocated per iteration 2,217,652,584 B/op 2,217,854,288 B/op 201,704 B/op
Allocs per iteration 30,843,619 allocs/op 30,844,779 allocs/op 1,160 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([2d152d7](https://github.com/k1LoW/runn/commit/2d152d71d024bf560c5f553dc331a6f34fc17b83)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkSingleRunbook-4

main (-) #1027 (2d152d7) +/-
Number of iterations 18 16 -2
Nanoseconds per iteration 64,157,968 ns/op 66,240,377 ns/op 2,082,409 ns/op
Bytes allocated per iteration 60,121,720 B/op 60,122,769 B/op 1,049 B/op
Allocs per iteration 205,410 allocs/op 205,406 allocs/op -4 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([2d152d7](https://github.com/k1LoW/runn/commit/2d152d71d024bf560c5f553dc331a6f34fc17b83)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

Reported by octocov

github-actions[bot] commented 2 weeks ago

BenchmarkManyRunbooks-4

main (-) #1027 (54e9183) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,842,544,891 ns/op 3,876,581,890 ns/op 34,036,999 ns/op
Bytes allocated per iteration 1,786,018,464 B/op 1,785,429,360 B/op -589,104 B/op
Allocs per iteration 21,135,183 allocs/op 21,134,711 allocs/op -472 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([54e9183](https://github.com/k1LoW/runn/commit/54e918323f1011ea35fd9644a72b5a54ff99eab7)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkOpenAPI3-4

main (-) #1027 (54e9183) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,793,383,666 ns/op 4,594,663,590 ns/op -198,720,076 ns/op
Bytes allocated per iteration 2,218,066,400 B/op 2,217,960,176 B/op -106,224 B/op
Allocs per iteration 30,843,111 allocs/op 30,843,108 allocs/op -3 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([54e9183](https://github.com/k1LoW/runn/commit/54e918323f1011ea35fd9644a72b5a54ff99eab7)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkSingleRunbook-4

main (-) #1027 (54e9183) +/-
Number of iterations 18 18 0
Nanoseconds per iteration 64,887,313 ns/op 64,276,697 ns/op -610,616 ns/op
Bytes allocated per iteration 60,141,249 B/op 60,120,060 B/op -21,189 B/op
Allocs per iteration 205,413 allocs/op 205,404 allocs/op -9 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#1027](https://github.com/k1LoW/runn/pull/1027) ([54e9183](https://github.com/k1LoW/runn/commit/54e918323f1011ea35fd9644a72b5a54ff99eab7)) | |------------|----------------------------------------------------:|--------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

Reported by octocov

github-actions[bot] commented 2 weeks ago

Code Metrics Report

main (7d0b671) #1027 (54e9183) +/-
Coverage 64.5% 64.4% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 5m35s 4m56s -39s
Details ``` diff | | main (7d0b671) | #1027 (54e9183) | +/- | |---------------------|----------------|-----------------|-------| - | Coverage | 64.5% | 64.4% | -0.1% | | Files | 78 | 78 | 0 | | Lines | 8667 | 8694 | +27 | + | Covered | 5591 | 5602 | +11 | - | Code to Test Ratio | 1:0.7 | 1:0.7 | -0.1 | | Code | 15940 | 15989 | +49 | + | Test | 11608 | 11617 | +9 | + | Test Execution Time | 5m35s | 4m56s | -39s | ```

Code coverage of files in pull request scope (61.1% → 60.7%)

Files Coverage +/-
http_validator.go 82.2% +0.7%
option.go 58.9% -0.7%
runner_option.go 35.1% -0.3%
testutil/http.go 90.0% +0.1%

Reported by octocov