k1LoW / runn

runn is a package/tool for running operations following a scenario.
https://runn.run
MIT License
433 stars 32 forks source link

Support `nullable: true` in HTTP validator ( Add more tests ) #879

Closed k1LoW closed 6 months ago

k1LoW commented 6 months ago

ref: #876

Thank you @h6ah4i !!

github-actions[bot] commented 6 months ago

BenchmarkManyRunbooks-4

main (-) #879 (bd30ee1) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,678,627,293 ns/op 3,847,926,290 ns/op 169,298,997 ns/op
Bytes allocated per iteration 1,792,291,120 B/op 1,792,439,496 B/op 148,376 B/op
Allocs per iteration 21,418,352 allocs/op 21,418,057 allocs/op -295 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#879](https://github.com/k1LoW/runn/pull/879) ([bd30ee1](https://github.com/k1LoW/runn/commit/bd30ee15a0d24fcead5f17729b889b0908001322)) | |------------|----------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkOpenAPI3-4

main (-) #879 (bd30ee1) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 53,140,337,849 ns/op 53,044,226,515 ns/op -96,111,334 ns/op
Bytes allocated per iteration 31,415,421,528 B/op 31,431,951,736 B/op 16,530,208 B/op
Allocs per iteration 310,820,838 allocs/op 310,833,440 allocs/op 12,602 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#879](https://github.com/k1LoW/runn/pull/879) ([bd30ee1](https://github.com/k1LoW/runn/commit/bd30ee15a0d24fcead5f17729b889b0908001322)) | |------------|----------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

BenchmarkSingleRunbook-4

main (-) #879 (bd30ee1) +/-
Number of iterations 18 16 -2
Nanoseconds per iteration 63,470,453 ns/op 63,359,413 ns/op -111,040 ns/op
Bytes allocated per iteration 60,176,136 B/op 60,192,123 B/op 15,987 B/op
Allocs per iteration 205,758 allocs/op 205,786 allocs/op 28 allocs/op
Metadata | | [main](https://github.com/k1LoW/runn/tree/main) (-) | [#879](https://github.com/k1LoW/runn/pull/879) ([bd30ee1](https://github.com/k1LoW/runn/commit/bd30ee15a0d24fcead5f17729b889b0908001322)) | |------------|----------------------------------------------------:|------------------------------------------------------------------------------------------------------------------------------------------:| | **goos** | linux | linux | | **goarch** | amd64 | amd64 | | **pkg** | github.com/k1LoW/runn | github.com/k1LoW/runn | | **cpu** | AMD EPYC 7763 64-Core Processor | AMD EPYC 7763 64-Core Processor |

Reported by octocov

github-actions[bot] commented 6 months ago

Code Metrics Report

main (7a82080) #879 (bd30ee1) +/-
Coverage 65.8% 65.8% +0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 4m0s 4m12s +12s
Details ``` diff | | main (7a82080) | #879 (bd30ee1) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 65.8% | 65.8% | +0.0% | | Files | 71 | 71 | 0 | | Lines | 7576 | 7588 | +12 | + | Covered | 4983 | 4992 | +9 | + | Code to Test Ratio | 1:0.7 | 1:0.7 | +0.0 | | Code | 13663 | 13687 | +24 | + | Test | 9912 | 10128 | +216 | - | Test Execution Time | 4m0s | 4m12s | +12s | ```

Code coverage of files in pull request scope (79.8% → 79.3%)

Files Coverage +/-
http_validator.go 79.3% -0.5%

Reported by octocov