k1LoW / runn

runn is a package/tool for running operations following a scenario.
https://runn.run
MIT License
417 stars 30 forks source link

Replace the buildTree() method by injected expr tracing approach #917

Closed h6ah4i closed 3 months ago

h6ah4i commented 3 months ago

Hi! I hope it will be a big step forward for runn and I'm so happy to introduce this improvement :tada:

What's new?

Drawbacks

Behind the scenes

At first, I was trying to implement my proposal of the issue #803. However, soon I realized the current buildTree() method is not robust and there is no enough room for future development. That is why I decided to re-implement the pretty printing feature for expr evaluation results in completely new way.

k1LoW commented 3 months ago

@h6ah4i GREAT WORK!!!!!!!!! Thank you!!

First of all, thank you. I will now check the code.

However, soon I realized the current buildTree() method is not robust and there is no enough room for future development.

I agree with you.

(breaking change) Removed YAML style # line comment handling.

This was granted at a time when expr-lang did not have the ability to comment, and should go away. However, we cannot suddenly lose it, so I will try to be able to give a message that it is deprecated ( and replace ^# to // simply).