k1LoW / serverless-s3-sync

A plugin to sync local directories and S3 prefixes for Serverless Framework :zap:
183 stars 70 forks source link

Adds support for fetching the bucket name from the stack output #37

Closed mpvosseller closed 4 years ago

mpvosseller commented 4 years ago

This PR allows the name of a bucket to optionally be fetched from the stack output. This is helpful when the name of the bucket is not known before the stack is created. In such cases the user can now write the name of the bucket as an Output value and provide the Output key as a bucketNameKey property.

This fixes issue #6.

The implementation is inspired from the serverless-cloudfront-invalidate plugin which does something very similar.

NOTE: Most of these changes are whitespace/indentation so in the diff view you might choose Diff Settings -> Hide whitespace changes.

k1LoW commented 4 years ago

Hi @mpvosseller ! GREAT !! Thank you !!!!

k1LoW commented 4 years ago

Released as v1.10.0.