search

k1LoW / serverless-s3-sync

A plugin to sync local directories and S3 prefixes for Serverless Framework :zap:
183 stars 70 forks source link

Skip get/putBucketTagging requests when bucketTags option is not configured #62

Closed coyoteecd closed 4 years ago

coyoteecd commented 4 years ago

Solves a bug that I introduced in previous pull request #61: when bucketTags setting is not specified, the plugin would still issue get/putBucketTagging requests to S3. These requests are unnecessary.

Furthermore (as it was my case), they were introducing a breaking change due to the fact that a deployment that worked before may fail to deploy if it does not have s3:PutBucketTagging and s3:GetBucketTagging permissions for the IAM role that executes the deployment.

Now we're skipping the bucket tag actions completely when bucketTags node is missing from the config.

k1LoW commented 4 years ago

Thank you !!

k1LoW commented 4 years ago

Released as v1.14.1.