k1LoW / serverless-s3-sync

A plugin to sync local directories and S3 prefixes for Serverless Framework :zap:
182 stars 68 forks source link

Add noSync property to s3Sync config #83

Closed frozenbonito closed 2 years ago

frozenbonito commented 3 years ago

Starting with v3.0.0, Serverless will report unrecognized options with a thrown error. https://www.serverless.com/framework/docs/deprecations/#handling-of-unrecognized-cli-options

--nos3sync will not work in Serverless v3, so makes configurable by autoSync property in s3Sync instead.

k1LoW commented 2 years ago

@frozenbonito Thank you for your commit!

--nos3sync will not work in Serverless v3, so makes configurable by autoSync property in s3Sync instead.

--nos3sync and autoSync have the opposite meaning. Is it possible to make them mean the same thing?

frozenbonito commented 2 years ago

@k1LoW

Thank you for review.

--nos3sync and autoSync have the opposite meaning. Is it possible to make them mean the same thing?

OK, I changed the autoSync property to noSync property.

k1LoW commented 2 years ago

@frozenbonito Thank you !!