search

k1LoW / tbls

tbls is a CI-Friendly tool for document a database, written in Go.
MIT License
3.5k stars 168 forks source link

Support Oracle database #155

Open jnahmias opened 4 years ago

jnahmias commented 4 years ago

It would be great if tbls supported the Oracle database.

YauhenPylAurea commented 2 years ago

Hello there, checking oracle support now... I am not sure how to write a unit test for it properly as there is no kind of official docker image with oracle db. I see there is a possibility to create your own image. But it seems it is not allowed to have such thing in GitHub actions to test oracle driver (or, by impression, it is not legal). @k1LoW do you have any idea how to overcome such issue? Any thoughts? Actually a unit test is blocking a pr with oracle db driver.

k1LoW commented 2 years ago

I am not sure how to write a unit test for it properly as there is no kind of official docker image with oracle db.

But it seems it is not allowed to have such thing in GitHub actions to test oracle driver (or, by impression, it is not legal).

I have given up testing Oracle database on GitHub Actions for the exact same reason.

However, drivers are independent of each other, so it is possible to first include it as an experimental implementation as like Snowflake, even without unittest.

However, I would like to have the document by tbls doc and its DDL for testing in my hand.

AizeLeOuf commented 1 year ago

Every official image is already available in github https://github.com/oracle/docker-images/tree/main/OracleDatabase/SingleInstance

k1LoW commented 1 year ago

Every official image is already available in github https://github.com/oracle/docker-images/tree/main/OracleDatabase/SingleInstance

Thank you. This appears to be an official build script, not an official image.

ref: https://github.com/oracle/docker-images/tree/main/OracleDatabase/SingleInstance#building-oracle-database-container-images

You will have to provide the installation binaries of Oracle Database (except for Oracle Database 18c XE, 21c XE and 23c FREE) and put them into the dockerfiles/ folder. You only need to provide the binaries for the edition you are going to install. The binaries can be downloaded from the Oracle Technology Network, make sure you use the linux link: Linux x86-64. The needed file is named linuxx64__database.zip.