search

k1LoW / tbls

tbls is a CI-Friendly tool for document a database, written in Go.
MIT License
3.4k stars 166 forks source link

doc: Add explanation for hide_auto_increment option #350

Closed tk0miya closed 2 years ago

tk0miya commented 2 years ago

It was added in #277. But it've never described in the README. This adds an explanation for hide_auto_increment option.

Thank you for creating such a wonderful tool :-)

tk0miya commented 2 years ago

Personally, it would be better to change this option enabled by default. I believe nobody will not get any information from AUTO_INCREMENT=[Redacted by tbls]. So I prefer to hide it by default and show it via option.

If you like to change this behavior, it would be better not to merge this. Because it's still a secret option.

k1LoW commented 2 years ago

Thank you for adding the documentation!

Personally, it would be better to change this option enabled by default.

Thank you for your feedback.

I think it would be better to have a default state that first shows the fact that tbls is redacting AUTO_INCREMENT information. Then, those who want to hide it can enable the hide_auto_increment option, and those who want to show it can enable the show_auto_increment option.

k1LoW commented 2 years ago

So I want to merge this PR. how do you think about it?

tk0miya commented 2 years ago

I'm not sure how AUTO_INCREMENT information is useful. So I'd like to vote to change the default behavior. But I'm follow your decision because we've already had this option :-)

k1LoW commented 2 years ago

Thank you !!!