search

k1LoW / tbls

tbls is a CI-Friendly tool for document a database, written in Go.
MIT License
3.34k stars 164 forks source link

#478: replace STRING_AGG to allow older MSSQL versions #502

Closed Lytchev closed 11 months ago

Lytchev commented 12 months ago

478: Replaced STRING_AGG (appeared in MSSQL 2017) with old-fashioned string aggregation

Lytchev commented 12 months ago

Missed issue #306 and unaccepted fix very similar to mine. Manual comparing of MSSQL queries execution results showed no difference to me on my DB, but unfortunately I have no idea of how to run project's tests.

k1LoW commented 11 months ago

Manual comparing of MSSQL queries execution results showed no difference to me on my DB, but unfortunately I have no idea of how to run project's tests.

I believe that merging is not a problem as long as there are no differences from the current document 👍

k1LoW commented 11 months ago

@Lytchev Great!! Thank you!!

I can't say it supports MSSQL2017 as I can't try it, but I can take in this Pull Request 👍