search

k1LoW / tbls

tbls is a CI-Friendly tool for document a database, written in Go.
MIT License
3.32k stars 164 forks source link

feat:refer viewpoints from tables #532

Closed majimaccho closed 8 months ago

majimaccho commented 8 months ago

fix: #526 based on discussion in https://github.com/k1LoW/tbls/pull/530.

To render link to viewpoints from the markdown, the OutputTable function has to know the index of the viewpoints, which was not included in Viewpoint type.

So I added TableViewpoint type like below.

struct TableViewpoint {
    Index Int
    Name String
    Desc String
}
majimaccho commented 8 months ago

@k1LoW https://github.com/k1LoW/tbls/actions/runs/6647754723/job/18063703113?pr=532 reviewdoc's golangci-lint timed out sometimes. You may want extend timeout (e.g. 5 minutes). If you want, I can include it in this PR.

k1LoW commented 8 months ago

If you want, I can include it in this PR.

Thank you!!!! Please!

k1LoW commented 8 months ago

Perhaps https://github.com/reviewdog/action-golangci-lint#golangci_lint_flags ?

majimaccho commented 8 months ago

Lint is just passed now by https://github.com/k1LoW/tbls/pull/532/commits/adc687d538f635a7e9147ef848a3719f73a2c34e Now golden files was missing so I added them

majimaccho commented 8 months ago

@k1LoW Sorry still tests are failing, I'd convert this to draft.

k1LoW commented 8 months ago

Feel free to trial and error without worrying about it 👍