Closed mjpieters closed 2 weeks ago
I suspect that these lint issues have been missed for some time because you set the golanglint
action to use the github-pr-check
reporter. These end up as error annotations on the workflow summary page (see my other PR workflow summary), and the lint check itself doesn't show an error.
I recommend you change the configuration for that action to make these more visible:
fail_on_error
to have the action fail the workflow when there are errors.reporter: github-pr-review
option is more visible.@mjpieters Thank you!! I am very pleased with these improvements.
filter.go
in 1bed38d)I really like being able to rely on
make lint
being clean, seeing errors there, even if not in my own PR changes, makes me itch. 😅Specifically, these lint issues have been addressed: