search

k2-fsa / icefall

https://k2-fsa.github.io/icefall/
Apache License 2.0
931 stars 295 forks source link

Minor error #1446

Closed AlexandderGorodetski closed 9 months ago

AlexandderGorodetski commented 10 months ago

In file ~/icefall/icefall/lm_wrapper.py line 162

vocab_size=params.vocab_size

should be replaced with

vocab_size=params.lm_vocab_size

marcoyang1998 commented 10 months ago

Thanks for pointing it out, would you mind making a PR to fix this?

AlexandderGorodetski commented 10 months ago

Could you please guide me how can I create PR ?

I guess that I should to perform following commands

git clone

changes

git add . git commit -m "comment" git pull

Is that correct? After such procedure the Pull Request will be created automatically ?

marcoyang1998 commented 10 months ago

You could have a look at this tutorial: https://opensource.com/article/19/7/create-pull-request-github

Basically, you need to

  1. create a fork of the project
  2. then clone the forked version;
  3. then create a new branch in you local codebase and commit the changes.
  4. Push the changes to github
  5. Create the pull request (you will be able to see this option on your github repo once you pushed the changes)
JinZr commented 9 months ago

closed as this PR https://github.com/k2-fsa/icefall/pull/1495 should fix the issue