Open AmirHussein96 opened 1 month ago
A separate one would be better, otherwise backward compatibility might be broken since you have also modified the default parameters of the export script.
On Sat, Apr 6, 2024 at 1:03 PM Amir Hussein @.***> wrote:
@.**** commented on this pull request.
On egs/librispeech/ASR/zipformer/export.py https://github.com/k2-fsa/icefall/pull/1582#discussion_r1554525321:
Since both are based on same zipformer architecture, I think they can use the same export, the difference is in the parameters. I could also create a separate one if needed.
— Reply to this email directly, view it on GitHub https://github.com/k2-fsa/icefall/pull/1582#discussion_r1554525321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOON42DLBNV26GBVPIGFVMLY356ZNAVCNFSM6AAAAABFZHCDSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBUGQ2DEMBXHA . You are receiving this because you commented.Message ID: @.***>
This pull request is for the SEAME recipe and includes the following: