k2-fsa / k2

FSA/FST algorithms, differentiable, with PyTorch compatibility.
https://k2-fsa.github.io/k2
Apache License 2.0
1.11k stars 213 forks source link

Typo in documentation #1161

Closed treya-lin closed 1 year ago

treya-lin commented 1 year ago

Not a big finding but just a minor typo in documentation:

https://k2-fsa.github.io/k2/core_concepts/index.html#example-1-autograd-in-tropical-semiring

fsa_vec = k2.create_fsa_vec([fsa])
total_scores = fsa.get_tot_scores(log_semiring=False, use_double_scores=False)

should be

fsa_vec = k2.create_fsa_vec([fsa])
total_scores = fsa_vec.get_tot_scores(log_semiring=False, use_double_scores=False)

right : )

csukuangfj commented 1 year ago

Yes, you are absolutely right.

Would you mind creating a pull-request to fix it?

treya-lin commented 1 year ago

Yes, you are absolutely right.

Would you mind creating a pull-request to fix it?

Sure. Just created it https://github.com/k2-fsa/k2/pull/1162 . Cheers.