search

k2-fsa / k2

FSA/FST algorithms, differentiable, with PyTorch compatibility.
https://k2-fsa.github.io/k2
Apache License 2.0
1.11k stars 213 forks source link

k2 build without pytorch #1164

Open zh794390558 opened 1 year ago

csukuangfj commented 1 year ago

@zh794390558 Thanks for your contribution!

Could you check whether the added code is covered by tests?

zh794390558 commented 1 year ago

Could you check whether the added code is covered by tests?

how to check it? I can not see the CI in this PR.

csukuangfj commented 1 year ago

Could you check whether the added code is covered by tests?

how to check it? I can not see the CI in this PR.

Did you run all the c++ tests locally?

zh794390558 commented 1 year ago

Did you run all the c++ tests locally?

I'm not, since test depends on pytorch also.

I build k2 with this option

cmake -B build -DK2_USE_PYTORCH=OFF -DK2_ENABLE_TESTS=OFF -DK2_ENABLE_BENCHMARK=OFF
csukuangfj commented 1 year ago

since test depends on pytorch also.

I think there are tests that don't depend on PyTorch.