search

k2-fsa / k2

FSA/FST algorithms, differentiable, with PyTorch compatibility.
https://k2-fsa.github.io/k2
Apache License 2.0
1.1k stars 214 forks source link

Remove c++14 overrides in torch/bin/CMakeLists #1211

Closed wrongbad closed 10 months ago

wrongbad commented 1 year ago

They inherit c++14 by default from top-level anyway

But override needs to be removed to link with recent torch builds which require c++17.

Now you can specify -DCMAKE_CXX_STANDARD=17 from CLI

csukuangfj commented 1 year ago

The current code also works for the latest PyTorch version, e.g., torch 2.0.1.

Could you describe what this PR tries to fix?

csukuangfj commented 10 months ago

Thanks! Fixed in #1249