search

k2-fsa / k2

FSA/FST algorithms, differentiable, with PyTorch compatibility.
https://k2-fsa.github.io/k2
Apache License 2.0
1.11k stars 213 forks source link

Update kaldifeat for gcc 13 #1251

Closed csukuangfj closed 11 months ago

csukuangfj commented 11 months ago

@meerfrau Please try this PR.

See also https://github.com/k2-fsa/k2/issues/1250

rouseabout commented 11 months ago

Applying this patch causes the following k2 build error.

python3 setup.py install

[...]

-- C++ Standard version: 17
-- BUILD_SHARED_LIBS ON
-- pybind11 is downloaded to /home/user/k2/build/temp.linux-x86_64-3.9/_deps/pybind11-src
CMake Error at cmake/pybind11.cmake:72 (add_subdirectory):
  The binary directory

    /home/user/k2/build/temp.linux-x86_64-3.9/_deps/pybind11-build

  is already used to build a source directory.  It cannot be used to build
  source directory

    /home/user/k2/build/temp.linux-x86_64-3.9/_deps/pybind11-src

  Specify a unique binary directory name.
Call Stack (most recent call first):
  cmake/pybind11.cmake:75 (download_pybind11)
  build/temp.linux-x86_64-3.9/_deps/kaldifeat-src/CMakeLists.txt:54 (include)

Appears both k2 and kaldifeat try to build pybind11?

csukuangfj commented 11 months ago

@rouseabout

Thanks for testing. Please use the latest commit of this PR.

I just updated the code to fix it.

rouseabout commented 11 months ago

Works. Thanks!

csukuangfj commented 11 months ago

Thank you again for testing. Merging.