k3ii / git-cz

A simple commitizen written in rust
Other
12 stars 2 forks source link

[BUG] Unable to use automatic signature settings for commit signing #41

Open nan-mu opened 4 weeks ago

nan-mu commented 4 weeks ago

Describe the bug This may be a bug or a feature request. I have used many tools similar to Git cz, and they all read commit.gpgSign=true and sign the commit accordingly. However, our tool does not; it even bypasses Git's commit signing check hook. In this sense, it doesn't work as expected.

To Reproduce I am signing with an SSH key. According to this article, the signing works correctly when I run git commit or git commit -S manually.

Expected behavior When I check with git show/log --show-signature, if the commit is properly signed, the output should display something like: Good "git" signature for my@email.com with RSA key SHA256:hash or something?

Screenshots image

Environment

Additional context

None

nan-mu commented 4 weeks ago

Of course, if you are a little busy, I might be able to take a look and submit a related PR this weekend. And I noticed that the git-cz command does not have --version

k3ii commented 2 weeks ago

Hello @nan-mu , thank you for opening this issue.

We can support commit signing using git2-ext. Or if you know a better way, please submit a PR.

About the --version, we can use the crate clap for it.

k3ii commented 2 weeks ago

Here's a blog explaining how to do sign commits in Rust.