howardjp
commented
5 years ago That's correct, but this is fixed in develop.
On Mon, Feb 11, 2019 at 12:39 PM ahood notifications@github.com wrote:
If I understand correctly from the Soundex algorithm steps on Wikipedia https://en.wikipedia.org/wiki/Soundex#American-Soundex, the encoding of e.g. the string 'A' should be 'A000'. Indeed this is what is produced by other Soundex implementations I'm looking at. However, phonics::soundex('A') returns 'A'.
Happy to make a pull request if you agree that 'A000' is the correct encoding.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/howardjp/phonics/issues/38, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJjag_7IGacWLIwZlr-oLFKsz13gm-Lks5vMaq9gaJpZM4a0s8Y .
ahood
If I understand correctly from the Soundex algorithm steps on Wikipedia, the encoding of e.g. the string 'A' should be 'A000'. Indeed this is what is produced by other Soundex implementations I'm looking at. However, phonics::soundex('A') returns 'A'.
Happy to make a pull request if you agree that 'A000' is the correct encoding and if you agree with the rule that "If you have too few letters in your word that you can't assign three numbers, append with zeros until there are three numbers" (quoting from Step 4 in the Wikipedia article).