k3ng / k3ng_cw_keyer

K3NG Arduino CW Keyer
http://blog.radioartisan.com/arduino-cw-keyer/
GNU General Public License v3.0
424 stars 220 forks source link

potentiometer_enable_pin definition missing in some hardware configurations #68

Closed rificity closed 5 years ago

rificity commented 5 years ago

I kept getting a compile error when working on a Nanokeyer Rev. D. The line - _#define potentiometer_enablepin 0 - is missing from several of the _keyer_pin_settingsxxxx.h files.

tulipman commented 5 years ago

Typo!!

There is a underscore missing

Sent from my iPhone XS Max (512Gb)

On 21 May 2019, at 16:29, Al Gritzmacher notifications@github.com wrote:

I kept getting a compile error when working on a Nanokeyer Rev. D. The line - #define potentiometer_enable_pin 0 - is missing from several of the keyer_pin_settings_xxxx.h files.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

rificity commented 5 years ago

No. I meant what I said. The line beginning with _#define potentiometer_enablepin is missing in both of the Nanokeyer hardware pin setting configurations. I have corrected it in my local copy, but don't know how to have it updated in the repository so that others don't have to track it down.

kriskirkland commented 5 years ago

I was able to fix this issue by adding the #define statement but see also issue #69 with the NanoKeyer rev D.

rificity commented 5 years ago

I was able to fix this issue by adding the #define statement but see also issue #69 with the NanoKeyer rev D.

As was I. My point is, the code should have that corrected so that every person that comes along with a Nanokeyer doesn't have to track it down.

kriskirkland commented 5 years ago

I was able to fix this issue by adding the #define statement but see also issue #69 with the NanoKeyer rev D.

As was I. My point is, the code should have that corrected so that every person that comes along with a Nanokeyer doesn't have to track it down.

I agree, I was just commiserating with you.

k3ng commented 5 years ago

This will be fixed shortly, version 2019.05.29.01. Thanks and 73