search

k3ng / k3ng_cw_keyer

K3NG Arduino CW Keyer
http://blog.radioartisan.com/arduino-cw-keyer/
GNU General Public License v3.0
416 stars 216 forks source link

Cmd mode r #95

Closed VK2EFL closed 4 years ago

VK2EFL commented 4 years ago

Anthony, Still a bit confused about this forking and branching stuff. I hope I got the new option included in all the relevant files. Although I did notice that some of the more recently added options were not in the files that I edited nor the main sketch. So I wonder if I got it right. 73 Fred VK2WS

k3ng commented 4 years ago

Hi Fred. There are a bunch of conflicts in this pull request, probably due to the recently added options that weren't in your files. I went ahead and implemented this feature as a single #define in the settings files. But thank you for your effort in implementing this.

VK2EFL commented 4 years ago

Anthony, OK, many ways to solve a problem. All good. I still don;t understand why when I did a branch of the master it copied a quite old version of the k3ng_keyer.ino sketch. I didn't check for the actual version number but I noticed that some of the more recently added options were not listed in the features_and_options.h files. My excuse it that it was getting late at night. 😖 73 Fred VK2WS

From: Anthony Good notifications@github.com Sent: Friday, 24 April 2020 11:14 PM To: k3ng/k3ng_cw_keyer k3ng_cw_keyer@noreply.github.com Cc: VK2EFL felodden@hotmail.com; Author author@noreply.github.com Subject: Re: [k3ng/k3ng_cw_keyer] Cmd mode r (#95)

Hi Fred. There are a bunch of conflicts in this pull request, probably due to the recently added options that weren't in your files. I went ahead and implemented this feature as a single #define in the settings files. But thank you for your effort in implementing this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/k3ng/k3ng_cw_keyer/pull/95#issuecomment-619001142, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBEJVQW4SYSP5ORGR32YQTROGGEHANCNFSM4MQANO7Q.