k3s-io / docs

k3s Documentation
http://docs.k3s.io
17 stars 129 forks source link

Fix the `curl` command for preparing k3s images for Airgap #243

Closed rishinair11 closed 7 months ago

rishinair11 commented 7 months ago

Fixes https://github.com/k3s-io/docs/issues/244

This fixes an invalid URL issue that curl throws.

$ sudo curl -L -O /var/lib/rancher/k3s/agent/images/k3s-airgap-images-amd64.tar.zst https://github.com/k3s-io/k3s/releases/download/v1.29.1-rc2%2Bk3s1/k3s-airgap-images-amd64.tar.zst
curl: (3) URL using bad/illegal format or missing URL
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

Since we are already passing the full path to the images.tar.zst, we can use -o instead of -O

brandond commented 7 months ago

yeah, -o is the correct option, not -O. You shouldn't need to quote the URL but it doesn't hurt anything.

rishinair11 commented 7 months ago

Thank you team. I appreciate the review!