search

k3s-io / helm-controller

Apache License 2.0
391 stars 85 forks source link

Is it possible to specify options --reuse-values, --reset-values? #174

Closed ahebibovic closed 1 year ago

ahebibovic commented 1 year ago

https://github.com/k3s-io/helm-controller/blob/master/pkg/apis/helm.cattle.io/v1/types.go#L32

I guess it can be done like this: https://github.com/k3s-io/helm-controller/pull/143

Thanks!

brandond commented 1 year ago

No, but I'm not sure these options would really be necessary, since all the values are persisted in the HelmChart and HelmChartValues resources themselves... given that the values are persisted externally, what would the use case be for using those options?

ahebibovic commented 1 year ago

I am going to use that from there. Thanks!

oivindoh commented 1 year ago

A use-case I can think of is if there's an issue with an image used by a helm chart, so you've overridden the image in your HelmChartConfig, but then the project releases a new chart version that points to a fixed image and you want to go back to using whichever image the chart specifies. Currently the previous value is sticky unless you explicitly set a new one, so new defaults are impossible to apply.

brandond commented 1 year ago

@oivindoh so you've overridden the image in your HelmChartConfig, but then the project releases a new chart version that points to a fixed image and you want to go back to using whichever image the chart specifies. Currently the previous value is sticky unless you explicitly set a new one, so new defaults are impossible to apply.

I don't believe that's true. Chart values ARE NOT sticky; the helm upgrade command is not run with --reuse-values, so if you remove the value from your HelmChartConfig, the chart will be redeployed without your custom value, and go back to using the chart default.