search

k3s-io / helm-controller

Apache License 2.0
391 stars 85 forks source link

Support set from HelmChartConfig #199

Open chinglinwen opened 1 year ago

chinglinwen commented 1 year ago

Why HelmChartConfig doesn't have set field in Spec, which means can't override HelmChart resource's set values ?

Both should support set values? ( say merge HelmChartConfig set into HelmChart's set. )

brandond commented 1 year ago

Use of set overrides everything from values, so those are effectively hard-coded and intentionally cannot be overridden by values from either the HelmChart or HelmChartConfig's ValuesContent. We intentionally don't allow further attempts to override these by allowing set on HelmChartConfig. What specifically are you trying to override that was passed via the set?