search

k3s-io / helm-controller

Apache License 2.0
380 stars 84 forks source link

Add Tolerations spec to chart configuration #221

Open danielkza opened 8 months ago

danielkza commented 8 months ago

This allows chart resources to specify additional tolerations.

The use case for this is making sure that CNI charts can be updated even when you accidentally deploy a chart config change that breaks the CNI itself.

npapapietro commented 3 months ago

Is this PR being held up over just DCO? I am interested in seeing this feature reviewed and added. If this is abandoned by the author I can pull it down and try and push over the finish line

brandond commented 3 months ago

No, we pushed back on this, and instead now expect CNIs to not add random taints that people have to work around in other projects. RKE2's packaged cilium now disables this: https://github.com/k3s-io/helm-controller/issues/151#issuecomment-1915223696