[Epic] k3s_server and k3s_agent tasks are not idempotent

[jon-stumpf]

The below tasks are repeated even when they are not needed. Fixes are forthcoming.

k3s_server

• [x] Download K3s binary, https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_server/tasks/main.yml#L13
• [ ] Copy K3s service file [Single], https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_server/tasks/main.yml#L26
• [ ] Copy config file to user home directory, https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_server/tasks/main.yml#L70
• [x] Add K3s autocomplete to user bashrc (#262), https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_server/tasks/main.yml#L78
• [x] Change server to API endpoint instead of localhost, https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_server/tasks/main.yml#L86

  k3s_agent

• [x] Download K3s binary, https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_agent/tasks/main.yml#L13
• [x] Copy K3s service file (#268), https://github.com/k3s-io/k3s-ansible/blob/19c206d0cb448a33c869bbb8e084653e111be582/roles/k3s_agent/tasks/main.yml#L23

[dereknola]

I assume most of this was me blindly putting in changed_when: true for these tasks :flushed:

[dereknola]

GH being dumb and autoclosing this issue.

[jon-stumpf]

FYI. I have been busy on other things and will be getting back to this after Christmas.

[alvsanand]

In step "Change server to API endpoint instead of localhost", kubeconfig must be set to "/etc/rancher/k3s/k3s.yaml". "~{{ ansible_user }}/.kube/config" is not used in the servers.

[dereknola]

Several more were addressed in https://github.com/k3s-io/k3s-ansible/pull/288