Open brandond opened 3 weeks ago
Attention: Patch coverage is 24.09091%
with 167 lines
in your changes are missing coverage. Please review.
Project coverage is 41.70%. Comparing base (
dba30ab
) to head (bcdd0be
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed Changes
--enable-pprof
to agent flag to allow profiling agents. Access to the pprof endpoint now requires client cert auth, similar to the spegel registry api endpoint.--supervisor-metrics
server flag that configures all cluster members (both servers and agents) to serve metrics at0.0.0.0:6443/metrics
.This is required to expose supervisor metrics on rke2; on k3s the metrics will be the same as those currently available from kubelet and apiserver metrics endpoints
Types of Changes
enhancement
Verification
metrics:
--supervisor-metrics
curl -vks --cert /var/lib/rancher/k3s/server/tls/client-admin.crt --key /var/lib/rancher/k3s/server/tls/client-admin.key https://node:6443/metrics
against agents and serverspprof:
curl -vks --cert /var/lib/rancher/k3s/server/tls/client-admin.crt --key /var/lib/rancher/k3s/server/tls/client-admin.key https://node:6443/debug/pprof/
against node with pprof enabledTesting
Linked Issues
User-Facing Change
Further Comments