Open huangzynn opened 2 weeks ago
In the future, PLEASE use the PR template, and create an issue to track the defect you are fixing. I'm not sure why you deleted it instead of at least filling out the proposed changes.
I've created an issue for this, and copied your text into the template.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.69%. Comparing base (
0981f00
) to head (b2f0f70
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed Changes
Allow helm controller set owner reference, when helm controller obj is deleteed , will delete helm-delete-job. If not set owner reference, the second installation and removal will fail Reference: https://github.com/k3s-io/helm-controller/blob/d74a09dfcaefdd6e8bea80d5aac66e70ea4e93d3/pkg/controllers/controllers.go#L144
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments