k3s-io / k3s

Lightweight Kubernetes
https://k3s.io
Apache License 2.0
26.62k stars 2.24k forks source link

Embedded helm controller does not track owner references properly #10051

Open brandond opened 2 weeks ago

brandond commented 2 weeks ago

The helm-controller refactor in in https://github.com/k3s-io/helm-controller/pull/157 added a WithSetOwnerReference(false, false) to the desiredset/apply controller, but that was missed when we pulled in the refactor into k3s in https://github.com/k3s-io/k3s/pull/6294.

As a result, the helm controller has been failing to properly track resource ownership, and owned objects are sometimes orphaned instead of being properly deleted.