k3s-io / k3s

Lightweight Kubernetes
https://k3s.io
Apache License 2.0
26.71k stars 2.24k forks source link

Bump spegel version #10118

Closed brandond closed 1 week ago

brandond commented 2 weeks ago

Proposed Changes

Bump Spegel version

Types of Changes

version bump

Verification

Testing

Linked Issues

User-Facing Change

Further Comments

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.77%. Comparing base (1d22b69) to head (1ac3cc5).

Files Patch % Lines
pkg/spegel/spegel.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #10118 +/- ## ========================================== - Coverage 47.58% 41.77% -5.82% ========================================== Files 173 173 Lines 14651 14653 +2 ========================================== - Hits 6972 6121 -851 - Misses 6348 7367 +1019 + Partials 1331 1165 -166 ``` | [Flag](https://app.codecov.io/gh/k3s-io/k3s/pull/10118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=k3s-io) | Coverage Δ | | |---|---|---| | [e2etests](https://app.codecov.io/gh/k3s-io/k3s/pull/10118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=k3s-io) | `36.38% <0.00%> (-9.89%)` | :arrow_down: | | [inttests](https://app.codecov.io/gh/k3s-io/k3s/pull/10118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=k3s-io) | `37.00% <0.00%> (+17.21%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/k3s-io/k3s/pull/10118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=k3s-io) | `11.37% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=k3s-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brandond commented 1 week ago

We're currently carrying 1 revert and 2 changes. one of the revert/changes is related to error handling, the other is related to wildcard support where upstream has taken a different approach than we support in registries.yaml.

https://github.com/spegel-org/spegel/compare/main...k3s-io:spegel:f3d2c40723149dcefc9b219dddc5bdd44cff0874