search

k3s-io / k3s

Lightweight Kubernetes
https://k3s.io
Apache License 2.0
26.71k stars 2.24k forks source link

Stop using deprecated functions from `k8s.io/apimachinery/pkg/util/wait` #9321

Open brandond opened 4 months ago

brandond commented 4 months ago

Upstream kubernetes deprecated several of the wait.Poll functions in 1.27.

Once 1.26 is end-of-life, we should replace all use of deprecated functions with the suggested 1.27+ replacements, and backport that change to all active branches.

willdot commented 3 months ago

I'd like to take this on if that's ok?

brandond commented 3 months ago

Sure! Note that we don't want to this until after the final 1.26 release, which should be in February I believe. Although upstream sometimes gives us bonus releases if there are regressions or vulns. So basically until after a month has gone by with no 1.26 patch.

willdot commented 3 months ago

That's no problem, I'm just looking for things to get stuck into when I get some free time :)

willdot commented 3 months ago

Guessing this still can't be completed due to a 1.26 release 2 weeks ago?

brandond commented 3 months ago

Yeah, we'll have to see if we get a 1.26 release in March. If not, then we can move forward with this.

willdot commented 3 weeks ago

The last 1.26 release was 14th March so it’s been over a month now.

https://github.com/kubernetes/kubernetes/releases/tag/v1.26.15

brandond commented 3 weeks ago

Yeah, maybe we can do this for June. We are likely not doing anything additional for May due to delays in updating some of our frameworks to 1.30.