search

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.56k stars 233 forks source link

Bump nats client to v1.17.1-0.20220923 #137

Closed caleblloyd closed 1 year ago

caleblloyd commented 1 year ago
brandond commented 1 year ago

Hmm, it looks like the tests for the new nats server versions failed due to the DB test never succeeding: https://drone-pr.k3s.io/k3s-io/kine/94/1/3

Does the DB_CONNECTION_TEST need to be updated for the new versions?

Also, does this imply that 2.7.4 is no longer supported?

caleblloyd commented 1 year ago

Is there a way to tell what specifically about the test is failing? All I see in the CI log is Test 2R88QL failed.

Also 2.7.4 should still work. But I thought that current version and previous minor version would be a good official support policy for NATS. Should we add a support matrix to the readme, and note that other versions may work as well, but are not officially tested or supported?

brandond commented 1 year ago

No, it doesn't capture the actual output of the connection test. Best bet would probably be to start the database pod using the create command, and then test it with the test command.

We don't have an official support matrix; I kinda consider the minor versions that we have in the tests to be supported so if we're dropping v2.7 from the tests that says something.

caleblloyd commented 1 year ago

I found the test issue, I had pasted an incorrect version into DB_CONNECTION_TEST; that is fixed

I am fine with keeping 2.7.4 in the tests... I don't think we necessarily need to test every minor version of NATS, I don't want to bog down CI as NATS keeps publishing minor releases. How does just testing 2.7.4 and the Current version of NATS sound? Made that change too

caleblloyd commented 1 year ago

Updated NATS client to v1.17.1-0.20220923 to take advantage of the KeyValueStatus.Bytes() method for DbSize(), should be ready for re-review

/cc @jnmoyne