Closed neoaggelos closed 1 year ago
https://github.com/kubernetes/kubernetes/commit/421213b7a17b4d2753b3a00b7332a4bec3aba127 is now checking that the delete response range is valid. Kine seems to be returning an invalid response, which contains a ResponseRange instead of a ResponseDeleteRange, looking at https://github.com/k3s-io/kine/blob/master/pkg/server/delete.go#L30-L50
ResponseRange
ResponseDeleteRange
I've done some early testing with fixing the response format, but not sure if there is a blast radius that I am missing. Hoping to get some feedback from kine maintainers.
I'm creating a PR with my work, let's see where the discussion takes us.
Summary
https://github.com/kubernetes/kubernetes/commit/421213b7a17b4d2753b3a00b7332a4bec3aba127 is now checking that the delete response range is valid. Kine seems to be returning an invalid response, which contains a
ResponseRange
instead of aResponseDeleteRange
, looking at https://github.com/k3s-io/kine/blob/master/pkg/server/delete.go#L30-L50I've done some early testing with fixing the response format, but not sure if there is a blast radius that I am missing. Hoping to get some feedback from kine maintainers.
I'm creating a PR with my work, let's see where the discussion takes us.