Closed dependabot[bot] closed 1 year ago
@macedogm the alpine version bump automation should probably handle bumping these as well.
@brandond yes, I believe that this is @matttrach's idea to start adding these automations to UpdateCLI now (after the basic files are working).
ooh, ok. so dependabot got the golang version, but not the alpine version... I will put this on the list of things to add to updatecli, thanks @brandond! @macedogm is right, rather than making one very large PR I have decided to make new PRs for each updatecli config, this will keep things simple to review and atomic if there are any issues.
FYI a good portion of the update logic can be re-used from https://github.com/k3s-io/k3s/blob/master/updatecli/updatecli.d/golang-alpine.yaml.
This is failing because of a shell construction that gave us problems in k3s as well after updating to a new version of alpine; we ended up refactoring to get rid of it entirely.
@brandond the fix was in PR https://github.com/k3s-io/k3s/pull/6744, right?
Note: before we merge this PR (after the shell issues are fixed), we must change its title from Bump golang from 1.19-alpine3.16 to 1.20-alpine3.16
to Bump golang from 1.19-alpine3.16 to 1.20-alpine3.17
, since we are also bumping Alpine's version.
Yes @macedogm it was this bit here that seemed to cause problems https://github.com/k3s-io/k3s/pull/6744/files#diff-de044cc47bd966537f11f53a4b7d604585b6f12037bb7887c296ae13cd04b913L341
@brandond okay, thanks! I'll try to submit a PR next Monday/Tuesday, if it's okay (this week is already packed).
Yeah no hurry!
@brandond PTAL https://github.com/k3s-io/kine/pull/174 I had to fix and do the bump on a separate PR, because I can't push this to branch. If https://github.com/k3s-io/kine/pull/174 is approved, this PR should be closed, please.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore
condition with the desired update_types
to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps golang from 1.19-alpine3.16 to 1.20-alpine3.16.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)