k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.

Apache License 2.0

1.54k stars 231 forks source link

[updatecli] Update the version in the validate file #171

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

[updatecli] Update the version in the validate file

Report

Source:
    ✔ [goTag] Get Go 1.20.2 tag(gittag)

Condition:
    ✔ [testVersionShouldMatchGoTag] (yaml)

Target:
    ✔ [updateValidateFile] Update the version in the validate file(yaml)

Changelog

Click to expand

```` ````

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

brandond commented 1 year ago

@macedogm this doesn't look right, does it?

macedogm commented 1 year ago

@brandond no it's not right. I believe that @matttrach already identified the issue and fixed in this commit https://github.com/k3s-io/k3s-upgrade/pull/59/commits/fa8b079521ef52b3aa90aa207c5d79f916091efc. It just needs to be ported to here now.

matttrach commented 1 year ago

yep, I will get a PR up for it.

matttrach commented 1 year ago

https://github.com/k3s-io/kine/pull/172 should resolve this issue

matttrach commented 1 year ago

In the mean time we should close this PR and make it try again.